Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36002 )
Change subject: arch/x86/Makefile.inc: Use the 'all' target to add common sources ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Decompressor stage is missing
what do you mean? Decompressor is not added to the 'all' target. Do you think it should?
IMHO yes, as you write *all* except SMM
The decompressor class is only a stub to load a compressed bootblock to sram, so it shouldn't matter for x86. The special 'all' class currently deals with classes that are more or less traditional 'stages' so places where you expect things like console, timestamps, gpio's, ... . I'm not sufficiently familiar with the decompressor class to know if it would be useful to add it to the all class as it would likely reduce the amount of files that could use 'all'.
Would 'all_stages' cover the current semantics better?