Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76091/comment/2310538f_8fdd386b : PS2, Line 9: FT6 : Infrastructure Roadmap"#57316 Is there an AMD bug to update the documentation for future SOCs?
https://review.coreboot.org/c/coreboot/+/76091/comment/d7038cf4_933d6483 : PS2, Line 12: Both SMU and FSP interpret configs > 3 as 3. Why does this require an extra call to the SMU to be performed, since it sounds like something they'd just handle on their own when given a value > 3?
https://review.coreboot.org/c/coreboot/+/76091/comment/53c37334_6f56844b : PS2, Line 15: TEST=Confirm extra message is not sent in serial log. Is there any validation of the DPTC settings themselves that can be done, to verify the new value doesn't cause a power/performance regression?
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
PS2: This change also needs to be made in `src/mainboard/google/skyrim/variants/winterhold/overridetree.cb`:
``` # Refer the spec "FT6 Infrastructure Roadmap"#57316 # Set system_configuration to 4 for 15W register "system_configuration" = "4" ```
https://review.coreboot.org/c/coreboot/+/76091/comment/1d42e890_b6be6103 : PS2, Line 264: # DPTC: Refer the spec "FT6 Infrastructure Roadmap"#57316 : # Set system_configuration to 3 for 15W : register "system_configuration" = "3" I think it would be good to add a comment here that the document is actually wrong, and why using `3` is the better/correct choice.