12 Nov
2022
12 Nov
'22
10:03 p.m.
Attention is currently required from: Elyes Haouas.
Ravi Mistry has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320 )
Change subject: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP) ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/mainboard/hp/memphis-s/romstage.c:
https://review.coreboot.org/c/coreboot/+/69320/comment/c9241465_3a685a3a PS6, Line 3: #include <stdint.h> : #include <northbridge/intel/haswell/haswell.h> : #include <northbridge/intel/haswell/raminit.h> : #include <southbridge/intel/lynxpoint/pch.h>
Please include only what you use
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21
Gerrit-Change-Number: 69320
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 12 Nov 2022 21:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr
Gerrit-MessageType: comment