Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31619 )
Change subject: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/acpi/gpio_o... File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/acpi/gpio_o... PS2, Line 115: , Arg1
makes sense, i will just use the mask to set/unset the bit
Good call, looks much better :)
https://review.coreboot.org/#/c/31619/4/src/soc/intel/cannonlake/acpi/gpio_o... File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/#/c/31619/4/src/soc/intel/cannonlake/acpi/gpio_o... PS4, Line 112: And (Arg1, 1, Arg1) This only adds odd side-effects (every other value above 1 means enable / disable?) and shouldn't be necessary.