Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83883?usp=email )
Change subject: soc/intel/common: fix CrashLog size in legacy mode ......................................................................
soc/intel/common: fix CrashLog size in legacy mode
Intel's PMC CrashLog size in legacy mode is expressed in DWORDs and therefore needs to be explicitly recalculated to bytes.
BUG=None TEST=Built and checked the size in logs
Change-Id: I2678d537439c24fbd10aa3ceffee63c9a849d28b Signed-off-by: Jędrzej Ciupis jciupis@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83883 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jakub Czapiga czapiga@google.com --- M src/soc/intel/common/block/crashlog/crashlog.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Jakub Czapiga: Looks good to me, approved
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 041c8bf..007b469 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -379,7 +379,7 @@ return; } pmc_crashLog_size = (discovery_buf.bits.size != 0) ? - discovery_buf.bits.size : 0xC00; + discovery_buf.bits.size * sizeof(u32) : 0xC00; printk(BIOS_DEBUG, "PMC crashLog size in legacy mode : 0x%X\n", pmc_crashLog_size); }