Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Matt DeVillier, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84365?usp=email )
Change subject: soc/intel/alderlake: Enable CRASHLOG for Chrome OS
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/84365/comment/5bc8f131_ca89852e?usp... :
PS1, Line 87: MAINBOARD_HAS_CHROMEOS
Fair enough. But currently there is no mechanism to disable the feature via Kconfig, and it doesn't appear to have been tested for the non-CHROMEOS use case.
I have guarded `MAINBOARD_HAS_CHROMEOS` to ensure atleast on ChromeOS devices, we have enabled and tested this feature started with ADL. Intel recently fixed some issues over Crashlog enablement in ADL as well.
This code will ensure crashlog config is only enabled for devices with CrOS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84365?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia23ef1cbebdba9a3b724204eb25ee788afa3e8fd
Gerrit-Change-Number: 84365
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Sep 2024 02:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com