Attention is currently required from: Arthur Heymans, Jakub Czapiga, Julius Werner, Jérémy Compostella, Matt DeVillier, Maximilian Brune, Philipp Hug, Simon Glass, ron minnich.
Lean Sheng Tan has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )
Change subject: [RFC] Add UPL FDT handoff
......................................................................
Patch Set 19:
(1 comment)
File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/76591/comment/ce54d089_6827eccd?usp... :
PS17, Line 194: # payload none only implies that we don't build with a payload, but it can later be added via CBFS, which makes creating handoff still necessary.
: choice
You can't have both. Either you pass FDT as argument to the payload or coreboot tables.
In the coreboot leadership meeting in 2022 I already explained that it is either or situation. There were some concerns during that meeting, but in the end the agreement was as long as this is not seeing as deprecating coreboot table and this is just merely providing an extra option for user to choose, then it is fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76591?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae
Gerrit-Change-Number: 76591
Gerrit-PatchSet: 19
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-CC: coreboot org
coreboot.org@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 12 Aug 2024 04:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org
coreboot.org@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com