Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 39: to fail.
This fits on the previous line (if the . […]
Done
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 5: ssm-f
I would use the full name: x11ssm-f
Done
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then?
I guess. […]
I don't want them to get merged; this is just a hint for review; this will get removed as soon as I am sure this can be removed
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
PS8:
Move to documentation?
Done