Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )
Change subject: soc/intel/common/block/cpu: Refactor init_cpus function ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... PS6, Line 136: init_cpus Just curious: Does this have to be done at a certain point after FSP-S init? I am thinking if it would be better to just make the call to init_cpus() be done from different boot state depending upon `USE_INTEL_FSP_MP_INIT`
https://review.coreboot.org/c/coreboot/+/44076/6/src/soc/intel/common/block/... PS6, Line 149: : microcode_patch = intel_microcode_find(); : intel_microcode_load_unlocked(microcode_patch); I know this change wasn't made here but since we are revisiting this path - how is microcode loading handled in case of FSP init? Isn't that required to be done at some point in coreboot?