Attention is currently required from: Nico Huber.
Hello Jakub Czapiga, Matt DeVillier, Nicholas Sudsgaard, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84088?usp=email
to look at the new patch set (#2).
Change subject: b64_decode-test: Properly terminate strings before comparison ......................................................................
b64_decode-test: Properly terminate strings before comparison
Undefined behavior in unit-tests is no fun. assert_string_equal() expects properly zero-terminated strings. None of the encoded test strings contain a termination, hence add it manually.
Without this change, the test was often failing with a wrong error message:
[==========] tests_lib_b64_decode-test(tests): Running 1 test(s). [ RUN ] test_b64_decode [ ERROR ] --- "AB" != "AB" [ LINE ] --- tests/lib/b64_decode-test.c:38: error: Failure! [ FAILED ] test_b64_decode [==========] tests_lib_b64_decode-test(tests): 1 test(s) run.
Probably due to unprintable characters in the string. No idea why my system is more susceptible to this issue.
Change-Id: Id1bd2c3ff06bc1d4e5aa21ddd0f1d5802540999d Signed-off-by: Nico Huber nico.h@gmx.de --- M tests/lib/b64_decode-test.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/84088/2