Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46821 )
Change subject: cpu/x86/mpinit/sipi_vector: Move code to C
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46821/4/src/cpu/x86/sipi_vector_c_h...
File src/cpu/x86/sipi_vector_c_handler.c:
https://review.coreboot.org/c/coreboot/+/46821/4/src/cpu/x86/sipi_vector_c_h...
PS4, Line 40: intel_microcode_load_unlocked
The update trigger mechanism is the same for AMD CPUs (wrmsr 0x79), maybe that can be placed in a more generic place as this seems to do more Intel specific things?
Looks like I was wrong. AMD use a different MSR for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6c2ffa2ce8c42eee9f3fe8ec8cff933942207ca
Gerrit-Change-Number: 46821
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Nov 2020 15:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment