Attention is currently required from: Paul Menzel, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84349?usp=email )
Change subject: soc/intel/common/block/acpi: exclude DMI fixed memory range if no DMI ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84349/comment/69d5727d_90577957?usp... : PS3, Line 7: soc/intel/common/block/acpi/exclude DMI fixed memory range if no DMI
I think the colon is missing to separate the prefix from the summary.
Done
https://review.coreboot.org/c/coreboot/+/84349/comment/f902d6cd_69930cac?usp... : PS3, Line 9: exclude DMI in northbridge.asl if DMI_BASE_SIZE is '0'
Why?
Done
https://review.coreboot.org/c/coreboot/+/84349/comment/4307a3a3_5372abd7?usp... : PS3, Line 9: exclude
Exclude
Done
File src/soc/intel/common/block/acpi/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/84349/comment/7b148e54_1403d535?usp... : PS3, Line 294: #if DMI_BASE_SIZE != 0
nit […]
Done