Julius Werner has posted comments on this change. ( https://review.coreboot.org/19477 )
Change subject: rockchip/rk3399: Add MIPI driver ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19477/5/src/soc/rockchip/rk3399/mipi.c File src/soc/rockchip/rk3399/mipi.c:
Line 432: mdelay(120);
The SOC tells the panel to enter the display mode, and then wait for the pa
So this is a panel-dependent value? Isn't there anything in the datasheet about how long the panel needs for this initialization? I would feel much better with that then "it seems to work with more than 120ms for some reason". (If we can't find a source, we should probably have a little more margin... maybe 150ms. But an official number would be much better.)