Attention is currently required from: Jakub Czapiga, Julius Werner.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: commonlib/bsd: Add strncat() and strcat() functions ......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS3:
Maybe at least start something in commonlib with these two functions (doesn't mean you have to por […]
Done
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/83765/comment/6299b984_40b019ce?usp... : PS4, Line 119: strcpy(dst + strlen(dst), src);
I still don't understand the problem of the current implementation. If I write […]
Because `strcpy` references `strlen`, I moved `strlen` to commonlib/bsd in CB:83830. Also, because `strcpy` is still in GPL, commonlib's `strcat` cannot reference that. Therefore I followed your suggestion (for a different reason though).