Attention is currently required from: Alper Nebi Yasak, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80363?usp=email )
Change subject: mainboard/qemu-riscv: Get top of memory from device-tree blob
......................................................................
Patch Set 2:
(1 comment)
File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80363/comment/f3660c6a_c89508ca :
PS2, Line 13: top = fdt_get_memory_top((void *)HLS()->fdt);
Breaks mb/spike-riscv build. […]
I wonder why they share a SoC. Though to me, the most straight forward option
seems to be the `if (CONFIG(FLATENED_DEVICE_TREE))`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e4a95f49ad373675939329eef40d7423a4132ab
Gerrit-Change-Number: 80363
Gerrit-PatchSet: 2
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-MessageType: comment