Attention is currently required from: Dinesh Gehlot, Jayvik Desai.
Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83667?usp=email )
Change subject: src: Enable config to determine eSOL status ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: ideally you can split this into three cls
1. CROS adding SOL Kconfig 2. libgfx select eSOL 3. MTL selects eSOL
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/83667/comment/d1327dae_1f886aa1?usp... : PS1, Line 55: MAINBOARD_HAS_EARLY_SIGN_OF_LIFE eSOL is a chromeos feature then why this is here ? i would request to have the config added as part of the ChromeOS directory like `CROS_ENABLES_ESOL` which should be only enabled with CROS build Kconfig and not directly like what you did from line 68 below