Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44565 )
Change subject: mb/google/zork: Always populate 2 channels in Trembyle APCB
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44565/2/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44565/2/src/soc/amd/picasso/Makefil...
PS2, Line 410: $$([ $(APCB_POPULATE_2ND_CHANNEL) = true ] && echo "--spd_1_0 $<")
Can you evaluate at Make time instead of bash? […]
This feedback was added to https://review.coreboot.org/c/coreboot/+/44480
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbc4816571c424e5efd8bb8d90707235d3c1754
Gerrit-Change-Number: 44565
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 21:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment