Maciej Matuszczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 4:
Patch Set 4:
(2 comments)
Patch Set 4: Code-Review+1
(3 comments)
Patch Set 1:
(3 comments)
I guess you messed up with git, but here are some comments about the gpio.c file.
yea fixed that
No, this is based on a parent that is not on gerrit...
Uhhh, I have written that file from scratch based on schematics and boardview.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 4
Gerrit-Owner: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 07 Oct 2019 21:16:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment