build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29966 )
Change subject: Mistral: qcs405: Add support for USB host mode ......................................................................
Patch Set 15:
(12 comments)
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c File src/soc/qualcomm/qcs405/usb.c:
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@145 PS15, Line 145: write8(&dwc3->usb2_phy_dig->override_x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@146 PS15, Line 146: dwc3->board_data->parameter_override_x0); code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@146 PS15, Line 146: dwc3->board_data->parameter_override_x0); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@149 PS15, Line 149: write8(&dwc3->usb2_phy_dig->override_x1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@150 PS15, Line 150: dwc3->board_data->parameter_override_x1); code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@150 PS15, Line 150: dwc3->board_data->parameter_override_x1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@153 PS15, Line 153: write8(&dwc3->usb2_phy_dig->override_x2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@154 PS15, Line 154: dwc3->board_data->parameter_override_x2); code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@154 PS15, Line 154: dwc3->board_data->parameter_override_x2); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@157 PS15, Line 157: write8(&dwc3->usb2_phy_dig->override_x3, please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@158 PS15, Line 158: dwc3->board_data->parameter_override_x3); code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/15/src/soc/qualcomm/qcs405/usb.c@158 PS15, Line 158: dwc3->board_data->parameter_override_x3); please, no spaces at the start of a line