Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Krystian Hebel, Kyösti Mälkki, Nico Huber.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77338?usp=email )
Change subject: device/pciexp_device.c: Fix setting Max Payload Size ......................................................................
Patch Set 19:
(3 comments)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/77338/comment/2fc8b46b_92475192 : PS18, Line 596: unsigned int
u16
All `pci_find_capability(dev, PCI_CAP_ID_PCIE);` calls were assigning a value to unsigned int (with a small u16 exceptions I made in `pcie_is_root_port` and `pcie_is_endpoint`, which I just have changed to unsigned int for consistency in patchset 19).
If you insist on using u16, I can make a follow-up patch to batch-change all `pci_find_capability(dev, PCI_CAP_ID_PCIE)` calls to assign a value to u16 in this file.
https://review.coreboot.org/c/coreboot/+/77338/comment/5e5cf38c_c0ddcbb8 : PS18, Line 610: unsigned int
u16
All `pci_find_capability(dev, PCI_CAP_ID_PCIE);` calls were assigning a value to unsigned int (with a small u16 exceptions I made in `pcie_is_root_port` and `pcie_is_endpoint`, which I just have changed to unsigned int for consistency in patchset 19).
If you insist on using u16, I can make a follow-up patch to batch-change all `pci_find_capability(dev, PCI_CAP_ID_PCIE)` calls to assign a value to u16 in this file.
https://review.coreboot.org/c/coreboot/+/77338/comment/99e854d8_cabe929f : PS18, Line 623: unsigned int
u16
All `pci_find_capability(dev, PCI_CAP_ID_PCIE);` calls were assigning a value to unsigned int (with a small u16 exceptions I made in `pcie_is_root_port` and `pcie_is_endpoint`, which I just have changed to unsigned int for consistency in patchset 19).
If you insist on using u16, I can make a follow-up patch to batch-change all `pci_find_capability(dev, PCI_CAP_ID_PCIE)` calls to assign a value to u16 in this file.