Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/58770
to review the following change.
Change subject: amd/lpc: Remove the weak function ......................................................................
amd/lpc: Remove the weak function
BUG=b:140165023
Change-Id: Idb4613dc08c8dee6c92b4dabb39c2f5c189471aa Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/include/amdblocks/lpc.h M src/soc/amd/common/block/lpc/lpc.c 2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/58770/1
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index daa51f1..09eafb8 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -141,8 +141,6 @@ /* Clear all decoding to the LPC bus and erase any range registers associated * with the enable bits. */ void lpc_disable_decodes(void); -/* LPC is typically enabled very early, but this function is last opportunity */ -void soc_late_lpc_bridge_enable(void); void lpc_enable_port80(void); void lpc_enable_pci_port80(void); void lpc_enable_decode(uint32_t decodes); diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 365c14dbf..496816b 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -20,9 +20,6 @@ #include <soc/lpc.h> #include <soc/southbridge.h>
-/* Most systems should have already enabled the bridge */ -void __weak soc_late_lpc_bridge_enable(void) { } - static void setup_serirq(void) { u8 byte; @@ -41,8 +38,6 @@ { u8 byte;
- soc_late_lpc_bridge_enable(); - /* Initialize isa dma */ isa_dma_init();