[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap().

[Jakub Czapiga (Code Review)]

Attention is currently required from: Konrad Adamczyk, Jason Glenesk, Raul Rangel, Matt DeVillier, Grzegorz Bernacki, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74716 )

Change subject: soc/amd/common/block: Add missing cbfs_unmap().
......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74716/comment/20dc4cee_efb1cf6d 
PS1, Line 16: Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1
Please fix: `No Signed-off-by line in commit message`

File src/soc/amd/common/block/cpu/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/74716/comment/486c85bd_c0043c1f 
PS1, Line 113: if (cpus_updated == get_cpu_count())
paranoid-nit: `>=`

File src/soc/amd/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/74716/comment/623a5431_7912517a 
PS1, Line 173: cbfs_unmap(rom);
There are scenarios where this call will be incorrect. `pci_rom_probe(dev)` does not guarantee the returned pointer to be a CBFS file. Right now `cbfs_unmap(ptr)` unmaps only pointers it had allocated but it's not guaranteed. Please see, if you can solve this some other way.