Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43281 )
Change subject: soc/amd/picasso: Drop the inclusion of entry16.ld and reset16.ld
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43281/2/src/soc/amd/picasso/memlayo...
File src/soc/amd/picasso/memlayout_x86.ld:
https://review.coreboot.org/c/coreboot/+/43281/2/src/soc/amd/picasso/memlayo...
PS2, Line 103: /* Trigger an error if I have an unuseable start address */
'unuseable' may be misspelled - perhaps 'unusable'?
It's a misspelling
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1218b24a06d0f69b856fb21458a6183fd21fcbc
Gerrit-Change-Number: 43281
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 22:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment