Attention is currently required from: Forest Mittelberg, Peter Marheine.
Hello Caveh Jalali, Forest Mittelberg, Peter Marheine, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84300?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: ec/google/chromeec: Ensure pre-CR50 devices use "short" battery strings ......................................................................
ec/google/chromeec: Ensure pre-CR50 devices use "short" battery strings
Commit b97ec4f0166b ("chromeec: support reading long battery strings") added support for reading long battery strings, but the method used to determine if this feature is supported causes Windows to hang when booting on older pre-CR50 ChromeOS devices. Add a short circuit to the BRSX method to ensure that pre-CR50 devices use older/shorter strings.
In testing, affected platforms were Broadwell/Braswell and earlier. Skylake is pre-CR50 as well, but unaffected. No adverse impact to grouping it with the others as those boards do not support or use longer battery strings.
TEST=build/boot Windows on google link, wolf, samus, chell and others. Verify boot successful and battery info populated correctly.
Change-Id: If3686dc9b82b44202947081ec7e253317deb8fff Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/84300/2