1 Nov
2019
1 Nov
'19
12:34 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )
Change subject: security/vboot/sync_ec: Add timestamps ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/36209/15/src/commonlib/include/comm... PS15, Line 198: body hash
Might want to specify *what* we're hashing here, now that we are adding EC hashing. […]
That's fair. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8
Gerrit-Change-Number: 36209
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 19:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching kitching@google.com
Gerrit-MessageType: comment