Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43294 )
Change subject: mb/google/dedede: Change HDMI DDC gpio to native function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43294/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/43294/1/src/mainboard/google/dedede...
PS1, Line 221: PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1),
For non-HDMI skus (without external PU on the DB), is there any impact here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If02f062132d7c3b01b07ea9401e81f451df35c3c
Gerrit-Change-Number: 43294
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Fri, 10 Jul 2020 03:46:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment