Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )
Change subject: Enable long cr50 ready pulses for Tigerlake systems
......................................................................
Patch Set 7:
Patch Set 7:
(2 comments)
I have moved the code out of the vboot directory.
I still think it is a superior solution to communicate with cr50 about the new register only once during boot, rather than dropping the CBMEM and reading the version/register again in early ramstage.
But that is at the complexity of making changes across different components which will probably be used only on this one board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83188fd09fe69c2cda4ce1a8bf5b2efe1ca86da
Gerrit-Change-Number: 43741
Gerrit-PatchSet: 7
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 00:09:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment