Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60564 )
Change subject: drivers/intel/gma/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ......................................................................
drivers/intel/gma/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
Replace `Multiply (a, b)` with `a * b`.
Change-Id: Idd77fa995e1edab86c509a88a1ba16d636c60b30 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60564 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index c168d63..564f182 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -53,7 +53,7 @@
/* Always keep BCLP up to date, even if driver is not ready. It requires a full 8-bit brightness value. 255 = 100% */ - Store (Divide (Multiply (Arg0, 255), 100), Local1) + Store (Divide (Arg0 * 255, 100), Local1) If (LGreater(Local1, 255)) { Store (255, Local1) } @@ -105,7 +105,7 @@
Method (XBCM, 1, NotSerialized) { - Store (DRCL (Multiply (Arg0, BCLM), 100), BCLV) + Store (DRCL (Arg0 * BCLM, 100), BCLV) }
/* Find value closest to BCLV in BRIG (which must be ordered) */ @@ -117,7 +117,7 @@ Return (Zero) } /* Local0: current percentage */ - Store (DRCL (Multiply (BCLV, 100), BCLM), Local0) + Store (DRCL (BCLV * 100, BCLM), Local0)
/* Local1: loop index (selectable values start at 2 in BRIG) */ Store (2, Local1)