Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62742 )
Change subject: ec/starlabs/merlin: Don't store EC values on change ......................................................................
ec/starlabs/merlin: Don't store EC values on change
Since CB:62741, the EC values are backed up to the CMOS when entering S3, S4 and S5. Consequently, they don't need to be stored when they're changed.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: If0ea392afae4a4d3c605cdea3c5896fbff606215 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62742 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/starlabs/merlin/variants/apl/events.asl M src/ec/starlabs/merlin/variants/cml/events.asl M src/ec/starlabs/merlin/variants/glk/events.asl M src/ec/starlabs/merlin/variants/kbl/events.asl M src/ec/starlabs/merlin/variants/merlin/events.asl M src/ec/starlabs/merlin/variants/tgl/events.asl 6 files changed, 16 insertions(+), 65 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/variants/apl/events.asl b/src/ec/starlabs/merlin/variants/apl/events.asl index e2c301b..57da405 100644 --- a/src/ec/starlabs/merlin/variants/apl/events.asl +++ b/src/ec/starlabs/merlin/variants/apl/events.asl @@ -36,22 +36,8 @@
Method (_Q08, 0, NotSerialized) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") } -// -// TODO: -// Below Q Events need to be added -// -// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock -// { -// TPLC = TPLE -// } -// -// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness -// { -// KLBC = KLBE -// } -//
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode { diff --git a/src/ec/starlabs/merlin/variants/cml/events.asl b/src/ec/starlabs/merlin/variants/cml/events.asl index 2eedb8e..00a2ca6 100644 --- a/src/ec/starlabs/merlin/variants/cml/events.asl +++ b/src/ec/starlabs/merlin/variants/cml/events.asl @@ -36,20 +36,17 @@
Method (_Q08, 0, NotSerialized) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") }
Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock { - TPLC = TPLE + Printf ("EC: Trackpad Lock") } -// -// TODO: -// Below Q Events need to be added -// -Method (_Q11) // Event: Keyboard Backlight Brightness + +Method (_Q11, 0, NotSerialized) // Event: Keyboard Backlight Brightness { - KLBC = KLBE + Printf ("EC: Keyboard Brightness") }
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode diff --git a/src/ec/starlabs/merlin/variants/glk/events.asl b/src/ec/starlabs/merlin/variants/glk/events.asl index e2c301b..2929421 100644 --- a/src/ec/starlabs/merlin/variants/glk/events.asl +++ b/src/ec/starlabs/merlin/variants/glk/events.asl @@ -36,23 +36,8 @@
Method (_Q08, 0, NotSerialized) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") } -// -// TODO: -// Below Q Events need to be added -// -// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock -// { -// TPLC = TPLE -// } -// -// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness -// { -// KLBC = KLBE -// } -// - Method (_Q99, 0, NotSerialized) // Event: Airplane Mode { ^^^^HIDD.HPEM (8) diff --git a/src/ec/starlabs/merlin/variants/kbl/events.asl b/src/ec/starlabs/merlin/variants/kbl/events.asl index 966365c..df7399d 100644 --- a/src/ec/starlabs/merlin/variants/kbl/events.asl +++ b/src/ec/starlabs/merlin/variants/kbl/events.asl @@ -34,25 +34,10 @@ ^^^^HIDD.HPEM (19) }
-Method (_Q08, 0, NotSerialized) // Event: Function Lock +Method (_Q08, 0, NotSerialized) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") } -// -// TODO: -// Below Q Events need to be added -// -// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock -// { -// TPLC = TPLE -// } -// -// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness -// { -// KLBC = KLBE -// KLSC = KLSE -// } -//
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode { diff --git a/src/ec/starlabs/merlin/variants/merlin/events.asl b/src/ec/starlabs/merlin/variants/merlin/events.asl index a732856..9835ef1 100644 --- a/src/ec/starlabs/merlin/variants/merlin/events.asl +++ b/src/ec/starlabs/merlin/variants/merlin/events.asl @@ -36,17 +36,16 @@
Method (_Q87) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") }
Method (_Q88) // Event: Trackpad Lock { - TPLC = TPLE + Printf ("EC: Trackpad Lock") } Method (_Q11) // Event: Keyboard Backlight Brightness { - KLBC = KLBE - KLSC = KLSE + Printf ("EC: Keyboard Brightness") }
Method (_Q99) // Event: Airplane Mode diff --git a/src/ec/starlabs/merlin/variants/tgl/events.asl b/src/ec/starlabs/merlin/variants/tgl/events.asl index 6963500..90cde39 100644 --- a/src/ec/starlabs/merlin/variants/tgl/events.asl +++ b/src/ec/starlabs/merlin/variants/tgl/events.asl @@ -36,17 +36,16 @@
Method (_Q87, 0, NotSerialized) // Event: Function Lock { - FLKC = FLKE + Printf ("EC: Function Lock") }
Method (_Q88, 0, NotSerialized) // Event: Trackpad Lock { - TPLC = TPLE + Printf ("EC: Trackpad Lock") } -Method (_Q4A) // Event: Keyboard Backlight Brightness +Method (_Q4A, 0, NotSerialized) // Event: Keyboard Backlight Brightness { - KLSC = KLSE - KLBC = KLBE + Printf ("EC: Keyboard Brightness") }
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.