Attention is currently required from: Felix Singer, Paul Menzel.
Reagan has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82506?usp=email )
Change subject: mb/razer/blade_stealth_kbl: Add H3Q variant
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/razer/blade_stealth_kbl/variants/h3q/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/82506/comment/20a83a26_e01c4a36?usp... :
PS10, Line 8: /* Pad configuration was generated automatically using intelp2m utility */
There's a suspiciously huge amount of GPO's. Just wondering, did you confirm […]
Yes, I used intelp2m and inteltool -g. Also the number of NC pads is the same as the other variant. I have no idea why there are so many enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I493a651e52c2eb938daa67a05e9caaa784020fa4
Gerrit-Change-Number: 82506
Gerrit-PatchSet: 10
Gerrit-Owner: Reagan
xbjfk.github@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 01 Jun 2024 11:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
