Attention is currently required from: Elyes Haouas, Julius Werner.
Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83503?usp=email )
Change subject: azalia: Get rid of "return {-1,0} ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83503/comment/63eecfea_ab2b8f3b?usp... : PS2, Line 9: Modern C uses {true,false}
No. Please see https://doc.coreboot.org/contributing/coding_style. […]
Done
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/83503/comment/4f54d826_352ddbf4?usp... : PS5, Line 56: if (azalia_exit_reset(base) == CB_ERR)
You should still test cb_errs for failure with `< 0` or `!= CB_SUCCESS`, unless you're really only l […]
Done