Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45590 )
Change subject: soc/intel/common/block/lpc: add acpi name
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/...
PS1, Line 101: return "LPCB";
One tab is enough
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/...
PS1, Line 112: .acpi_name = lpc_acpi_name,
Looks like the other entries are aligned with tabs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45590
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If418c83caafe5d9e2af135a8946cbe5eb687b9ef
Gerrit-Change-Number: 45590
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 02:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment