Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42226 )
Change subject: mb/google/zork: Enable psp_verstage
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42226/3/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42226/3/src/mainboard/google/zork/K...
PS3, Line 125: #TODO: Change these to get the postition from the FMAP file
bug #?
Removed - The todo wasn't needed, it's tracked in the bug but the code stands as it is.
https://review.coreboot.org/c/coreboot/+/42226/3/src/mainboard/google/zork/K...
PS3, Line 159: # TODO: Remove after testing is complete
bug # to remove or date that it should be removed by?
Removed todo.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6a12c2074d7c84c0cb766393c66f5eff29a58d5
Gerrit-Change-Number: 42226
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jun 2020 13:48:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment