22 Feb
2019
22 Feb
'19
8:45 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31285 )
Change subject: mb/intel/../../cml_u: Override LPSS related FSP UPD for CMLRVP ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31285/5/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31285/5/src/mainboard/intel/coffeelake_rvp/K... PS5, Line 25: OVERRIDE_DEVICETREE
What is the point of OVERRIDE_DEVICETREE if: […]
Agree with furquan, override model might not applicable for cml_rvp. hence we can get rid of that
--
To view, visit https://review.coreboot.org/c/coreboot/+/31285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82e3323df952762e2d9c14f1e3cfa75872ccc9b4
Gerrit-Change-Number: 31285
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Feb 2019 04:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment