build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44725 )
Change subject: soc/mediatek/mt8192: Do dramc after calibration settings ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 4896: void enable_write_DBI_after_calibration(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 4906: mr13 = (mr13 & ~ BIT(6)) | (fsp << 6); space prohibited after that '~' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 4908: mr03 = (mr03 & ~ BIT(7)) | (cali->w_dbi[fsp] << 7); space prohibited after that '~' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 4916: void dramc_set_mr13_vrcg_to_normal(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 4922: u8 mr13 = mr_value->mr13[rk] & ~ BIT(3); space prohibited after that '~' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44725/1/src/soc/mediatek/mt8192/dra... PS1, Line 3018: void after_calib(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"