Gerd Hoffmann (kraxel@redhat.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6773
-gerrit
commit 79a3a6cb86c87151192692f0798c3bcba6c7a7f5 Author: Gerd Hoffmann kraxel@redhat.com Date: Wed Aug 27 13:22:20 2014 +0200
qemu: make MAX_ACPI_SIZE big enougth for qemu 2.1+
The size allocated for acpi tables in the recently released qemu 2.1 version has changed. In 2.0 it was automatically sized according to the actual size of the acpi tables. Which caused problems because the allocation size could change depending on qemu version and guest configuration. Now it is 128k fixed, which should be enougth even for very large guests.
Problem with that is that MAX_ACPI_SIZE is 45k, i.e. too small. This patch simply increases MAX_ACPI_SIZE, unconditionally, to fix this problem.
I'm open to suggestions how to fix that in a better way, we probably don't want apply this to all boards. Ideas coming to mind is to #ifdef that depending on CONFIG_BOARD_EMULATION_QEMU_X86. Or add a new kconfig option which boards can set.
Comments? Better ideas?
Change-Id: I1268a4a443583f7a856d4b2e6416b866026d52bc Signed-off-by: Gerd Hoffmann kraxel@redhat.com --- src/arch/x86/boot/tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/boot/tables.c b/src/arch/x86/boot/tables.c index 16c752a..895798c 100644 --- a/src/arch/x86/boot/tables.c +++ b/src/arch/x86/boot/tables.c @@ -109,7 +109,7 @@ void write_tables(void) #endif /* CONFIG_GENERATE_MP_TABLE */
#if CONFIG_GENERATE_ACPI_TABLES -#define MAX_ACPI_SIZE (45 * 1024) +#define MAX_ACPI_SIZE (129 * 1024) post_code(0x9c);
/* Write ACPI tables to F segment and high tables area */