Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34130 )
Change subject: soc/intel/cannonlake: Enable FSP to use coreboot stack ......................................................................
Patch Set 4:
(1 comment)
Patch Set 2:
(2 comments)
Is this tested on CFL, CNL, WHL and CML? What happens if you use a FSP2.0 binary with this?
This is tested on CML platforms, if we don't enable the config with v1263(start of shared stack support(FSP 2.1 feature)), we see hang in memory init call, where is fails to call a mem init API due to stack constraints.
Well, but what happens with an FSP2.0 binary? This change affects all platforms mentioned above. Will their existing binaries work with PLATFORM_USES_FSP2_1 selected?
The changes are not compatible with FSP 2.0 and would see a FSP returning with error code. Revised code in PS#4 to limit common stack feature to CML.
https://review.coreboot.org/c/coreboot/+/34130/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34130/2//COMMIT_MSG@10 PS2, Line 10: 2.1 config, that enables support for coreboot to support shared stack with FSP.
Please adhere to the 72-char line-length limit in commit messages.
Done