Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Trevor Wu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: support max98390 audio amp
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/cherry/chromeos.c:
https://review.coreboot.org/c/coreboot/+/63083/comment/3d0b9d44_b7b38d44
PS4, Line 26:
Can we add static assertion that exactly one of CHERRY_USE_* is set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490
Gerrit-Change-Number: 63083
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment