[coreboot-gerrit] Change in coreboot[master]: [RFC] device: Add method for configuring bus master based on config o...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )

Change subject: [RFC] device: Add method for configuring bus master based on config option
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42459/8/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/42459/8/src/device/Kconfig@520 
PS8, Line 520: Enable
> This should say `allow` too. And some help text would be nice that this […]

maybe: "Allow PCI bus master bit to be enabled by coreboot"?

Of course, to enforce that better, we'd could use some way to guard against it happening in the future. Someone could still go pci_or_config16(blah blah blah, PCI_COMMAND_MASTER).

What about a linter for usage of PCI_COMMAND_MASTER as well?