Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42798 )
Change subject: drivers/mrc_cache: Avoid unused variable assignment
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c...
PS1, Line 456: boot_device_spi_flash
No. Previously, every call to "nvm_protect" would call `boot_device_spi_flash`. […]
Sorry, I meant *false* indeed.
`boot_device_init()` is called by that function. I believe the SPI flash API ensures, the device is initialized each time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c94b123f4994eed9d7568b63971fd5b1d94bc09
Gerrit-Change-Number: 42798
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 26 Jun 2020 12:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment