Attention is currently required from: Martin Roth, Dtrain Hsu, Henry Sun.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51844 )
Change subject: mb/google/dedede/var/cret: Support LTE module
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/dedede/variants/cret/gpio.c:
https://review.coreboot.org/c/coreboot/+/51844/comment/da38a3b7_e8425940
PS5, Line 19: PAD_CFG_GPO(GPP_D0, 1, DEEP),
This pin is reserve only now and non-stuff so it doesn't affect power on/off sequence. […]
Do you mind adding the reason regarding why ODM EE tends to set this pin to output high as a comment here? We dont want to accidentally remove the configuration.
File src/mainboard/google/dedede/variants/cret/variant.c:
https://review.coreboot.org/c/coreboot/+/51844/comment/1ef4b75a_c7bd72e4
PS5, Line 18: Once the FW_CONFIG is provisioned, power off LTE module only under
: * the situation where it is stuffed.
Not at all. Will go back here once FW_CONFIG is provisioned.
Is there a bug raised for that. If so can you please put a TODO(b/<bug_number>):
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14684bb30e46bf845a401649f56b16b60db379e8
Gerrit-Change-Number: 51844
Gerrit-PatchSet: 5
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Comment-Date: Tue, 30 Mar 2021 15:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment