Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56829 )
Change subject: mb/google/dedede/variants/haboki: add discrete TPM in overridetree ......................................................................
mb/google/dedede/variants/haboki: add discrete TPM in overridetree
Haboki is project which use discrete TPM, so add discrete TPM and disable cr50 in overrideree.
BUG=b:187094464 TEST=FW_NAME=haboki emerge-keeby coreboot chromeos-bootimage
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: I08f2a562c3f62c60402350151ea260b70890a744 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56829 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/dedede/variants/haboki/overridetree.cb 1 file changed, 9 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/haboki/overridetree.cb b/src/mainboard/google/dedede/variants/haboki/overridetree.cb index aebfdcd..b4f312f 100644 --- a/src/mainboard/google/dedede/variants/haboki/overridetree.cb +++ b/src/mainboard/google/dedede/variants/haboki/overridetree.cb @@ -18,10 +18,6 @@ #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ - .gspi[0] = { - .speed_mhz = 1, - .early_init = 1, - }, .i2c[0] = { .speed = I2C_SPEED_FAST, }, @@ -46,6 +42,9 @@
register "tcc_offset" = "20" # TCC of 85C
+ register "SerialIoGSpiMode[PchSerialIoIndexGSPI0]" = "PchSerialIoDisabled" # Disable GSPI0 + register "SerialIoGSpiCsMode[PchSerialIoIndexGSPI0]" = "0" + # Enable Acoustic noise mitigation and set slew rate to 1/4 # Rest of the parameters are 0 by default. register "AcousticNoiseMitigation" = "1" @@ -296,6 +295,12 @@ device i2c 1a on end end end #I2C 4 + device pci 1f.0 on + chip drivers/pc80/tpm + device pnp 0c31.0 on end # Discrete TPM + end # chip drivers/pc80/tpm + end # PCH eSPI + device pci 1e.2 off end # GSPI 0 device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98360A""