Attention is currently required from: Forest Mittelberg, Matt DeVillier.
Peter Marheine has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84300?usp=email )
Change subject: [RFC] ec/google/chromeec: Guard reading long battery strings ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Do you know what Windows is doing that causes it to hang, or did you just bisect to the battery change without looking too deeply into what's happening?
EC communication seems like it shouldn't depend on the presence of a Google security chip so I suspect there's something deeper happening, but I don't mind this change as-is since I'm not concerned about availability of this feature on systems that lack a GSC.
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/84300/comment/d26f474e_ac81b544?usp... : PS1, Line 174: #if CONFIG(TPM_GOOGLE_CR50) || CONFIG(TPM_GOOGLE_TI50) Seems simpler to put these guards inside BRSX (short-circuit to `BRSS=0`), so it only needs to be in one place.