[coreboot-gerrit] [S] Change in coreboot[master]: mb/google: Move declaration of tis_plat_irq_status to cr50.h

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Christian Walter, Grzegorz Bernacki, Jason Nien, Martin Roth, Vadim Bendebury, Yidi Lin.

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75917?usp=email )

Change subject: mb/google: Move declaration of tis_plat_irq_status to cr50.h
......................................................................

Patch Set 2:

(1 comment)

File src/drivers/tpm/cr50.h:

https://review.coreboot.org/c/coreboot/+/75917/comment/783acfcd_7b82db52 :
PS2, Line 28: tis_plat_irq_status
> I will rename the funcion, but for now I will not move the weak implementation yet. […]

Moving the declaration and moving the 2 weak implementations look like the same thing, so I think they should be done in the same patch. In fact, aren't these 2 weak functions almost identical? It should be pretty easy to merge them.

If you care about different timeouts (10ms vs 20ms), a Kconfig option (similar to `GOOGLE_TPM_IRQ_TIMEOUT_MS`) can be added. However I doubt that the weak implementations are actually used for any board, because each `GOOGLE_BOARD_*` should have its own implementation of `tis_plat_irq_status`. If that's the case, always delaying 20ms should be good enough.