Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144199): https://review.coreboot.org/c/coreboot/+/62903/comment/4d0e3e20_4cd4d0a4 PS1, Line 21: //.port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} // TODO: uncomment this when PSPP is working line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144199): https://review.coreboot.org/c/coreboot/+/62903/comment/a3b2bcef_d56987f8 PS1, Line 48: //.port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} // TODO: uncomment this when PSPP is working line over 96 characters