Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48220 )
Change subject: soc/amd: move smi_util to common block
......................................................................
Patch Set 1:
Patch Set 1:
smi_util.c from picasso was a 1:1 copy of the stoneyridge code
the mapping of things to the sci number is different in the socs, but i kept that part in the soc/smi.h headers. if you think that i should verify the code also applies to the next generation, i can have a look at it again tomorrow
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f930287840bf7aa958f19786c7f1146c683c93e
Gerrit-Change-Number: 48220
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 23:09:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment