Attention is currently required from: Karthik Ramasubramanian, Shelley Chen, Sowmya Aralguppe, Subrata Banik.
Sumeet R.P. has posted comments on this change by Sumeet R.P.. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email )
Change subject: mb/google/brox/variants/brox: remove PL4 value modification ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
please consider this patch to be abandoned and review this patch instead https://review.coreboot. […]
I would request to keep this original patch to take it forward and merge, instead of this one https://review.coreboot.org/c/coreboot/+/84185
Commit Message:
https://review.coreboot.org/c/coreboot/+/83662/comment/4c262888_b24a3ec9?usp... : PS1, Line 8: : Remove PL4 value modification based on PsysPL3 valuei. :
the motivation not clear? can you please give a reason why it existed before and why you are not rem […]
PL4 value should not be configure/modify based on PsysPL3.
It was showing wrong PL4 value on the system with earlier patch [https://review.coreboot.org/c/coreboot/+/83087/6/src/mainboard/google/brox/v... line#160].
This patch corrects it by removing this code.