Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31368 )
Change subject: soc/intel/skylake: Avoid TOL_1V8 being set for GPP_F4 ~ GPP_F11
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31368/6/src/soc/intel/common/block/gpio/gpio...
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/31368/6/src/soc/intel/common/block/gpio/gpio...
PS6, Line 282: if (cfg->pad >= GPP_F4 && cfg->pad <= GPP_F11 &&
suspect code indent for conditional statements (16, 23)
i actually can't understand what build bod mean.
this line should be indented properly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419ef3e89104ad3611e96bbe23a582504b45be0c
Gerrit-Change-Number: 31368
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Feb 2019 09:16:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment