Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31999 )
Change subject: soc/intel/common: Move support to log XHCI wake events ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/Kconfig File src/soc/intel/common/Kconfig:
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/Kconfig@71 PS1, Line 71: SOC_INTEL_COMMON_ELOG_XHCI
Move to soc/intel/common/block/xhci/Kconfig
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/elog_xhci.h File src/soc/intel/common/elog_xhci.h:
PS1:
Changes in this file can be moved to soc/intel/common/block/include/intelblocks/xhci. […]
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/elog_xhci.h@4 PS1, Line 4: * Copyright 2019 Google, Inc.
I was informed this is supposed to be Google, LLC
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/elog_xhci.h@23 PS1, Line 23: usb2_port_status_reg
Can you please add a comment indicating that this is the offset of the USB2 port status register wit […]
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/common/elog_xhci.h@30 PS1, Line 30: bool
Comment indicating what the return value means?
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/skylake/elog.c File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/#/c/31999/1/src/soc/intel/skylake/elog.c@47 PS1, Line 47: struct
const
Done
https://review.coreboot.org/#/c/31999/1/src/soc/intel/skylake/elog.c@127 PS1, Line 127: PCH_DEV_XHCI
I see other uses of PCH_DEV_* in soc/intel/common/block. […]
Done