Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms
......................................................................
Patch Set 23:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34537/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34537/22//COMMIT_MSG@10
PS22, Line 10: set up as 1024x768@16.
Sorry, can you please add what happens if a different resolution/depth is used?
Done
https://review.coreboot.org/c/coreboot/+/34537/22//COMMIT_MSG@17
PS22, Line 17: This was testend on the wip razer blade stealth using the intel vgabios.
What resolution did you test with?
Done
https://review.coreboot.org/c/coreboot/+/34537/22//COMMIT_MSG@17
PS22, Line 17: testend
tested
Done
https://review.coreboot.org/c/coreboot/+/34537/23/src/device/oprom/yabel/vbe...
File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/34537/23/src/device/oprom/yabel/vbe...
PS23, Line 38: #include <boot/coreboot_tables.h>
I think it's not needed anymore
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ab7b8a0f28badaa16e25dbe807158870d06e26a
Gerrit-Change-Number: 34537
Gerrit-PatchSet: 23
Gerrit-Owner: Johanna Schander
coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Johanna Schander
coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 16:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment